Add from_config to sampler #803
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mattdangerw
force-pushed
the
sampler-from-config
branch
from
4d7f117 to
9833a0e
Compare
sampathweb
approved these changes
Mar 2, 2023
Every class with a get_config should have a from_config somewhere in the super() chain. This is actually causing test failures on nightly. Also fix some unit testing to not rely on the specific dictionary structure of a serialized object, which is changing across keras versions.
mattdangerw
force-pushed
the
sampler-from-config
branch
from
9833a0e to
9d2179e
Compare
mattdangerw
added a commit
that referenced
this pull request
Mar 3, 2023
Every class with a get_config should have a from_config somewhere in the super() chain. This is actually causing test failures on nightly. Also fix some unit testing to not rely on the specific dictionary structure of a serialized object, which is changing across keras versions.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Every class with a get_config should have a from_config somewhere in the super() chain. This is actually causing test failures on nightly.